Re: [libvirt] [PATCH 11/21] tests: qemuxml2argv: remove unused DO_TEST_CAPS* macros

2019-03-19 Thread Ján Tomko
On Tue, Mar 19, 2019 at 02:31:47PM +0100, Andrea Bolognani wrote: On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: [...] -# define DO_TEST_CAPS(name, ver) \ -DO_TEST_CAPS_FULL(name, 0, 0, ver) I fail to see why this one existed in the first place - isn't it basically the same as DO_

Re: [libvirt] [PATCH 11/21] tests: qemuxml2argv: remove unused DO_TEST_CAPS* macros

2019-03-19 Thread Andrea Bolognani
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: [...] > -# define DO_TEST_CAPS(name, ver) \ > -DO_TEST_CAPS_FULL(name, 0, 0, ver) I fail to see why this one existed in the first place - isn't it basically the same as DO_TEST_CAPS_VER()? Reviewed-by: Andrea Bolognani -- Andrea Bolog

[libvirt] [PATCH 11/21] tests: qemuxml2argv: remove unused DO_TEST_CAPS* macros

2019-03-14 Thread Cole Robinson
They are potentially useful at the moment, but we will be making things much more flexible Signed-off-by: Cole Robinson --- tests/qemuxml2argvtest.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 1ce8bade48..130ab29d6e 100