Re: [libvirt] [PATCH 14/16] snapshot: Move snapshot list code into generic file

2019-03-21 Thread Eric Blake
On 3/21/19 7:33 PM, John Ferlan wrote: > > > On 3/20/19 1:41 AM, Eric Blake wrote: >> Finish the code motion of generic moment list handling. Well, mostly - >> we need to convert to using virObject to get polymorphic cleanup >> functions (so for now there are still a few lingering ties specific t

Re: [libvirt] [PATCH 14/16] snapshot: Move snapshot list code into generic file

2019-03-21 Thread Eric Blake
On 3/21/19 7:33 PM, John Ferlan wrote: > > > On 3/20/19 1:41 AM, Eric Blake wrote: >> Finish the code motion of generic moment list handling. Well, mostly - >> we need to convert to using virObject to get polymorphic cleanup >> functions (so for now there are still a few lingering ties specific t

Re: [libvirt] [PATCH 14/16] snapshot: Move snapshot list code into generic file

2019-03-21 Thread John Ferlan
On 3/20/19 1:41 AM, Eric Blake wrote: > Finish the code motion of generic moment list handling. Well, mostly - > we need to convert to using virObject to get polymorphic cleanup > functions (so for now there are still a few lingering ties specific to > snapshots). In this case, I kept virDomain

[libvirt] [PATCH 14/16] snapshot: Move snapshot list code into generic file

2019-03-19 Thread Eric Blake
Finish the code motion of generic moment list handling. Well, mostly - we need to convert to using virObject to get polymorphic cleanup functions (so for now there are still a few lingering ties specific to snapshots). In this case, I kept virDomainSnapshotObjList as a wrapper type around the new