Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-09-01 Thread Daniel P. Berrange
On Tue, Sep 01, 2009 at 02:58:12PM -0400, Miloslav Trmac wrote: > - "Daniel P. Berrange" wrote: > > > > I reckon this snippet of code could usefully be put into the util.h file > > > > as virFileGenerateRandomkey(), or alternatively perhaps secret_conf.h, > > > > as virSecretGenerateRandomKey

Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-09-01 Thread Miloslav Trmac
- "Daniel P. Berrange" wrote: > > > I reckon this snippet of code could usefully be put into the util.h file > > > as virFileGenerateRandomkey(), or alternatively perhaps secret_conf.h, > > > as virSecretGenerateRandomKey(unsigned char *buf, size_t buflen); > > This code, with its limitation

Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-09-01 Thread Daniel P. Berrange
On Tue, Sep 01, 2009 at 11:49:14AM -0400, Miloslav Trmac wrote: > - "Daniel P. Berrange" wrote: > > > > +/* A qcow passphrase is up to 16 bytes, with any data following a NUL > > > + ignored. Prohibit control and non-ASCII characters to avoid > > > possible > > > + unpleasan

Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-09-01 Thread Miloslav Trmac
- "Daniel P. Berrange" wrote: > On Thu, Aug 20, 2009 at 08:18:13PM +0200, Miloslav Trma?? wrote: > > If the element does not specify a secret > > during volume creation, generate a suitable secret and add it to the > > tag. The caller can view the updated tag > > using virStorageVolGetXMLD

Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-08-27 Thread Daniel P. Berrange
On Thu, Aug 20, 2009 at 08:18:13PM +0200, Miloslav Trma?? wrote: > If the element does not specify a secret > during volume creation, generate a suitable secret and add it to the > tag. The caller can view the updated tag > using virStorageVolGetXMLDesc(). > > Similarly, when is specified whi

[libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-08-20 Thread Miloslav Trmač
If the element does not specify a secret during volume creation, generate a suitable secret and add it to the tag. The caller can view the updated tag using virStorageVolGetXMLDesc(). Similarly, when is specified while creating a qcow or qcow2-formatted volume, change the format to "qcow" and

[libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-08-16 Thread Miloslav Trmač
If the element does not specify a secret during volume creation, generate a suitable secret and add it to the tag. The caller can view the updated tag using virStorageVolGetXMLDesc(). Similarly, when is specified while creating a qcow or qcow2-formatted volume, change the format to "qcow" and

[libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

2009-08-04 Thread Miloslav Trmač
If the element does not specify a secret during volume creation, generate a suitable secret and add it to the tag. The caller can view the updated tag using virStorageVolGetXMLDesc(). Similarly, when is specified while creating a qcow or qcow2-formatted volume, change the format to "qcow" and