Re: [libvirt] [PATCH 17/16] snapshot: Store qemu snapshot state in bulk

2019-03-25 Thread Eric Blake
On 3/25/19 12:19 PM, Daniel P. Berrangé wrote: > On Fri, Mar 22, 2019 at 01:07:04PM -0500, Eric Blake wrote: >> [keeping context, because of adding Dan in cc] >>> To some degree we could be 'stuck with' the model for snapshots, but >>> that doesn't mean checkpoints couldn't make use of some newer >

Re: [libvirt] [PATCH 17/16] snapshot: Store qemu snapshot state in bulk

2019-03-25 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 01:07:04PM -0500, Eric Blake wrote: > [keeping context, because of adding Dan in cc] > > To some degree we could be 'stuck with' the model for snapshots, but > > that doesn't mean checkpoints couldn't make use of some newer > > functionality that stores everything in one fil

Re: [libvirt] [PATCH 17/16] snapshot: Store qemu snapshot state in bulk

2019-03-22 Thread Eric Blake
[keeping context, because of adding Dan in cc] On 3/22/19 9:35 AM, John Ferlan wrote: > > > On 3/20/19 5:32 PM, Eric Blake wrote: >> Rather than one file per snapshot, store all qemu snapshots in a >> single file, using the recently added bulk snapshot list >> operations. For now, this doesn't c

Re: [libvirt] [PATCH 17/16] snapshot: Store qemu snapshot state in bulk

2019-03-22 Thread John Ferlan
On 3/20/19 5:32 PM, Eric Blake wrote: > Rather than one file per snapshot, store all qemu snapshots in a > single file, using the recently added bulk snapshot list > operations. For now, this doesn't change how often libvirt writes a > snapshot file, but it does open the door for the next patch

[libvirt] [PATCH 17/16] snapshot: Store qemu snapshot state in bulk

2019-03-20 Thread Eric Blake
Rather than one file per snapshot, store all qemu snapshots in a single file, using the recently added bulk snapshot list operations. For now, this doesn't change how often libvirt writes a snapshot file, but it does open the door for the next patch to update the signature to qemuDomainSnapshotWrit