Re: [libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-23 Thread Peter Krempa
On 04/23/14 18:18, Eric Blake wrote: > On 04/20/2014 04:13 PM, Peter Krempa wrote: >> To avoid having the root of a backing chain present twice in the list we >> need to invert the working of virStorageFileGetMetadataRecurse. >> > >> /* Recursive workhorse for virStorageFileGetMetadata. */ >> s

Re: [libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-23 Thread Eric Blake
On 04/20/2014 04:13 PM, Peter Krempa wrote: > To avoid having the root of a backing chain present twice in the list we > need to invert the working of virStorageFileGetMetadataRecurse. > > /* Recursive workhorse for virStorageFileGetMetadata. */ > static int > -virStorageFileGetMetadataRecurse

Re: [libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-22 Thread Eric Blake
On 04/20/2014 04:13 PM, Peter Krempa wrote: > To avoid having the root of a backing chain present twice in the list we > need to invert the working of virStorageFileGetMetadataRecurse. > > Until now the recursive worker created a new backing chain element from > the name and other information pass

[libvirt] [PATCH 18/18] util: storage: Invert the way recursive metadata retrieval works

2014-04-20 Thread Peter Krempa
To avoid having the root of a backing chain present twice in the list we need to invert the working of virStorageFileGetMetadataRecurse. Until now the recursive worker created a new backing chain element from the name and other information passed as arguments. This required us to pass the data of