Re: [libvirt] [PATCH 19/21] tests: qemuxml2argv: move DO_TEST qemuCaps init

2019-03-19 Thread Andrea Bolognani
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: [...] > +if (gic && testQemuCapsSetGIC(info->qemuCaps, gic) < 0) > +goto cleanup; Please change the first part of the condition to 'gic != GIC_NONE' so that it doesn't implicitly rely on the actual value. Reviewed-by: Andrea Bolo

[libvirt] [PATCH 19/21] tests: qemuxml2argv: move DO_TEST qemuCaps init

2019-03-14 Thread Cole Robinson
Move DO_TEST* qemuCaps init into testInfoSetArgs. This is a step towards unifying the different test macro implementations Signed-off-by: Cole Robinson --- tests/qemuxml2argvtest.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tests/qemuxml2argvtes