Hi Daniel,
> > +char g_szVBoxErrMsg[256];
>
> I don't much like the static fixed size error message buffer
Fixed this.
> > +if (conn->uri == NULL) {
> > +conn->uri = xmlParseURI(uid ? "vbox:///session" :
> > "vbox:///system"); +if (conn->uri == NULL) {
> > +vboxEr
On Thu, Apr 09, 2009 at 11:25:08AM +0200, Pritesh Kothari wrote:
> Hi All,
>
> Resending the second patch [PATCH 2/2] after fixing the Bug mentioned by
> Florian on the list.
>
> Regards,
> Pritesh
>
> On Wednesday 08 April 2009 14:20:29 Pritesh Kothari wrote:
> > Hi All,
> >
> > I have attache
Hi Florian,
> I've just had time to test start, shutdown, dominfo and list but works
> great so far :) Tomorrow I'll probably try define create VRDP etc...
>
> Just one quick patch though:
> I'm not sure you know, but you call VBoxCGlueInit() twice at every start
> of virsh: once in vboxRegister()
I've just had time to test start, shutdown, dominfo and list but works
great so far :) Tomorrow I'll probably try define create VRDP etc...
Just one quick patch though:
I'm not sure you know, but you call VBoxCGlueInit() twice at every start
of virsh: once in vboxRegister() and once in vboxInitial
On Tue, Mar 24, 2009 at 05:33:21PM +0100, Pritesh Kothari wrote:
> > I guess Dan did a more complete review of the code than mine. One of the
> > issues I had was many pieces of code licenced under the MIT Licence,
> > which is compatible with the LGPL, but I must admit that if you are the
> > auth
Hi Daniel,
> > I have a single template file called vbox_tmpl.c which is included
> > multiple times during compilation using some pre-processor magic, for
> > example:
>
> I hit that last Friday while starting to review the patch an found
> that a bit strange.
I couldn't think of any other cle
On Tue, Mar 24, 2009 at 09:51:20AM +0100, Pritesh Kothari wrote:
> > > +/** @file vbox_tmpl.c
> > > + * Template File to support multiple versions of VirtualBox
> > > + * at runtime :).
> >
> > Can you explain a little about this idea... & how it works
>
> First I will give the problem being faced
Hi Daniel,
> These two should just return 0, and then the 'open' method
> should return VIR_ERR_DECLINED if called with a virtualbox
> URI.
> > +else
> > +return -1;
> Likewise, this should just return 0;
oops sorry, will change that.
> > +/** @file vbox_tmpl.c
> > + * Template File
On Wed, Mar 18, 2009 at 06:44:50PM +0100, Pritesh Kothari wrote:
> Hi All,
>
> I have attached a patch which when applied on the HEAD as of today would
> allow virtualbox support in libvirt.
>
> The patch works very well with the VirtualBox OSE version and the 2.2 Beta
> release.
I've not got a
