Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

2016-05-10 Thread Erik Skultety
On 10/05/16 15:17, Michal Privoznik wrote: > On 05.05.2016 13:49, Erik Skultety wrote: >> Unlike the previous commit, we do actually support one client-side only flag >> VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag >> has to be masked out before sending a message to the

Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

2016-05-10 Thread Michal Privoznik
On 05.05.2016 13:49, Erik Skultety wrote: > Unlike the previous commit, we do actually support one client-side only flag > VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag > has to be masked out before sending a message to the daemon, otherwise it > would trigger an error w

Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

2016-05-05 Thread Erik Skultety
On 05/05/16 14:13, Peter Krempa wrote: > On Thu, May 05, 2016 at 13:49:24 +0200, Erik Skultety wrote: >> Unlike the previous commit, we do actually support one client-side only flag >> VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag >> has to be masked out before sending a

Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

2016-05-05 Thread Peter Krempa
On Thu, May 05, 2016 at 13:49:24 +0200, Erik Skultety wrote: > Unlike the previous commit, we do actually support one client-side only flag > VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag > has to be masked out before sending a message to the daemon, otherwise it > would

[libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

2016-05-05 Thread Erik Skultety
Unlike the previous commit, we do actually support one client-side only flag VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag has to be masked out before sending a message to the daemon, otherwise it would trigger an error when checking flags on the daemon side. Signed-off