Re: [libvirt] [PATCH 2/2] fs: Fix probing on no-overwrite of target device

2016-11-24 Thread Ján Tomko
On Mon, Nov 21, 2016 at 05:42:15PM -0500, John Ferlan wrote: [...] [C] might be more user-friendly, but I'm not sure if we can change the meaning of the NO_OVERWRITE constant like that. On the bright side, if blkid can also identify partition tables, we could unify the probing code with the dis

Re: [libvirt] [PATCH 2/2] fs: Fix probing on no-overwrite of target device

2016-11-21 Thread John Ferlan
[...] > > [C] might be more user-friendly, but I'm not sure if we can change the > meaning of the NO_OVERWRITE constant like that. On the bright side, > if blkid can also identify partition tables, we could unify the probing > code with the disk backend and stop parsing parted's output (also, catc

Re: [libvirt] [PATCH 2/2] fs: Fix probing on no-overwrite of target device

2016-11-18 Thread John Ferlan
On 11/18/2016 07:56 AM, Ján Tomko wrote: > On Tue, Nov 15, 2016 at 06:48:03PM -0500, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1363586 >> >> There's actually a couple of bugs here... >> >>only the "input" format type, so any other "types" of format would be > > I coul

Re: [libvirt] [PATCH 2/2] fs: Fix probing on no-overwrite of target device

2016-11-18 Thread Ján Tomko
On Tue, Nov 15, 2016 at 06:48:03PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1363586 There's actually a couple of bugs here... only the "input" format type, so any other "types" of format would be I could a verb. filtered during the blkid_do_probe resulting

[libvirt] [PATCH 2/2] fs: Fix probing on no-overwrite of target device

2016-11-15 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1363586 There's actually a couple of bugs here... only the "input" format type, so any other "types" of format would be filtered during the blkid_do_probe resulting in allowing a new format type to overwrite a previous format type since when