Re: [libvirt] [PATCH 2/2] fsync new storage volumes even if new volume was copied.

2010-07-20 Thread Laine Stump
On 07/19/2010 07:16 PM, Eric Blake wrote: On 07/19/2010 05:08 PM, Laine Stump wrote: Originally the storage volume files were opened with O_DSYNC to make sure they were flushed to disk immediately. It turned out that this was extremely slow in some cases, so the O_DSYNC was removed in favor of

Re: [libvirt] [PATCH 2/2] fsync new storage volumes even if new volume was copied.

2010-07-19 Thread Eric Blake
On 07/19/2010 05:08 PM, Laine Stump wrote: > Originally the storage volume files were opened with O_DSYNC to make > sure they were flushed to disk immediately. It turned out that this > was extremely slow in some cases, so the O_DSYNC was removed in favor > of just calling fsync() after all the dat

[libvirt] [PATCH 2/2] fsync new storage volumes even if new volume was copied.

2010-07-19 Thread Laine Stump
Originally the storage volume files were opened with O_DSYNC to make sure they were flushed to disk immediately. It turned out that this was extremely slow in some cases, so the O_DSYNC was removed in favor of just calling fsync() after all the data had been written. However, this call to fsync was