Re: [libvirt] [PATCH 2/2] qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev

2019-01-11 Thread Ján Tomko
On Fri, Jan 11, 2019 at 07:44:38AM -0500, John Ferlan wrote: On 1/11/19 3:26 AM, Ján Tomko wrote: On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote: It's essentially dead code. The only way hostdev->shareable can be true is during virDomainHostdevDefParseXML when the result of virHo

Re: [libvirt] [PATCH 2/2] qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev

2019-01-11 Thread John Ferlan
On 1/11/19 3:26 AM, Ján Tomko wrote: > On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote: >> It's essentially dead code. The only way hostdev->shareable >> can be true is during virDomainHostdevDefParseXML when the >> result of virHostdevIsSCSIDevice is true. > > While this might be t

Re: [libvirt] [PATCH 2/2] qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev

2019-01-11 Thread Ján Tomko
On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote: It's essentially dead code. The only way hostdev->shareable can be true is during virDomainHostdevDefParseXML when the result of virHostdevIsSCSIDevice is true. While this might be true in our current codebase, I don't think this func

[libvirt] [PATCH 2/2] qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev

2019-01-10 Thread John Ferlan
It's essentially dead code. The only way hostdev->shareable can be true is during virDomainHostdevDefParseXML when the result of virHostdevIsSCSIDevice is true. Signed-off-by: John Ferlan --- src/qemu/qemu_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu