Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-21 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > If a -drive has no image, using image properties makes qemu whine that > they should not be used. > > This patch stops formating cache/readonly/... for empty drives > for the pre-blockdev syntax. Unfortunately those parameters can't b

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-21 Thread Peter Krempa
On Wed, Jan 16, 2019 at 12:15:51 +, Daniel Berrange wrote: > On Wed, Jan 16, 2019 at 01:12:01PM +0100, Peter Krempa wrote: > > On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote: > > > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > > > > If a -drive has no image, usi

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 01:12:01PM +0100, Peter Krempa wrote: > On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote: > > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > > > If a -drive has no image, using image properties makes qemu whine that > > > they should not be used

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Peter Krempa
On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote: > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > > If a -drive has no image, using image properties makes qemu whine that > > they should not be used. > > > > This patch stops formating cache/readonly/... for empty dri

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote: > If a -drive has no image, using image properties makes qemu whine that > they should not be used. > > This patch stops formating cache/readonly/... for empty drives > for the pre-blockdev syntax. Unfortunately those parameters can't b

[libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive

2019-01-16 Thread Peter Krempa
If a -drive has no image, using image properties makes qemu whine that they should not be used. This patch stops formating cache/readonly/... for empty drives for the pre-blockdev syntax. Unfortunately those parameters can't be added later when inserting media, but on the other hand qemu will star