Re: [libvirt] [PATCH 2/2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

2017-12-20 Thread Ján Tomko
On Mon, Dec 18, 2017 at 09:28:24AM +0100, Michal Privoznik wrote: On 12/15/2017 08:48 PM, John Ferlan wrote: On 12/12/2017 08:36 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1448149 If a domain has no numa nodes, that means we don't put any memory-backend-file onto

Re: [libvirt] [PATCH 2/2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

2017-12-18 Thread John Ferlan
On 12/18/2017 03:28 AM, Michal Privoznik wrote: > On 12/15/2017 08:48 PM, John Ferlan wrote: >> >> >> On 12/12/2017 08:36 AM, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1448149 >>> >>> If a domain has no numa nodes, that means we don't put any >>> memory-backend-file

Re: [libvirt] [PATCH 2/2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

2017-12-18 Thread Michal Privoznik
On 12/15/2017 08:48 PM, John Ferlan wrote: > > > On 12/12/2017 08:36 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1448149 >> >> If a domain has no numa nodes, that means we don't put any >> memory-backend-file onto the qemu command line. That in turn >> means we can'

Re: [libvirt] [PATCH 2/2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

2017-12-15 Thread John Ferlan
On 12/12/2017 08:36 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1448149 > > If a domain has no numa nodes, that means we don't put any > memory-backend-file onto the qemu command line. That in turn > means we can't set access='shared'. Therefore, we should produce >

[libvirt] [PATCH 2/2] qemuBuildMemPathStr: Forbid memoryBacking/access for non-numa case

2017-12-12 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1448149 If a domain has no numa nodes, that means we don't put any memory-backend-file onto the qemu command line. That in turn means we can't set access='shared'. Therefore, we should produce an error instead of ignoring the setting silently. Signed-of