Re: [libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-20 Thread Martin Kletzander
On Wed, May 20, 2015 at 01:53:14PM +0200, Michal Privoznik wrote: On 19.05.2015 19:15, Martin Kletzander wrote: On Tue, May 19, 2015 at 01:33:11PM +0200, Michal Privoznik wrote: This API does not work well on domains without . It blindly reports misleading info on a shutoff domain: # virsh nu

Re: [libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-20 Thread Michal Privoznik
On 19.05.2015 19:15, Martin Kletzander wrote: > On Tue, May 19, 2015 at 01:33:11PM +0200, Michal Privoznik wrote: >> This API does not work well on domains without . It blindly >> reports misleading info on a shutoff domain: >> >> # virsh numatune rhel7 >> numa_mode : strict >> numa_nodeset

Re: [libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-19 Thread Martin Kletzander
On Tue, May 19, 2015 at 01:33:11PM +0200, Michal Privoznik wrote: This API does not work well on domains without . It blindly reports misleading info on a shutoff domain: # virsh numatune rhel7 numa_mode : strict numa_nodeset : This is obviously wrong as long as there's no numatune fo

[libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-19 Thread Michal Privoznik
This API does not work well on domains without . It blindly reports misleading info on a shutoff domain: # virsh numatune rhel7 numa_mode : strict numa_nodeset : This is obviously wrong as long as there's no numatune for rhel7 domain, which isn't. What we should do, is report only th