Re: [libvirt] [PATCH 2/2] qemuProcessStop: Simulate blockjob --abort on destroy

2019-11-19 Thread Michal Privoznik
On 11/19/19 10:31 AM, Peter Krempa wrote: On Tue, Nov 19, 2019 at 10:14:09 +0100, Michal Privoznik wrote: In subject, please remove 'Simulate blockjob --abort' and replace it e.g. with: 'remove image metadata for running mirror jobs' or something similar, because this patch does not really do an

Re: [libvirt] [PATCH 2/2] qemuProcessStop: Simulate blockjob --abort on destroy

2019-11-19 Thread Peter Krempa
On Tue, Nov 19, 2019 at 10:14:09 +0100, Michal Privoznik wrote: In subject, please remove 'Simulate blockjob --abort' and replace it e.g. with: 'remove image metadata for running mirror jobs' or something similar, because this patch does not really do anything with the job itself. > If user start

[libvirt] [PATCH 2/2] qemuProcessStop: Simulate blockjob --abort on destroy

2019-11-19 Thread Michal Privoznik
If user starts a blockcommit without --pivot then we modify access for qemu on both images and leave it like that until pivot is executed. So far so good. Problem is, if user instead of issuing pivot calls destroy on the domain. In this case we don't ever clear the access we granted at the beginnin