Re: [libvirt] [PATCH 2/3]: Log argv passed to virExec and virRun

2008-11-04 Thread Daniel P. Berrange
On Mon, Nov 03, 2008 at 11:21:26AM -0500, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Thu, Oct 30, 2008 at 02:06:20PM -0400, Cole Robinson wrote: > > > >> The attached patch logs the the argv's passed to > >> the virExec and virRun functions. There's a bit of > >> trickery here: sinc

Re: [libvirt] [PATCH 2/3]: Log argv passed to virExec and virRun

2008-11-03 Thread Cole Robinson
Daniel P. Berrange wrote: > On Thu, Oct 30, 2008 at 02:06:20PM -0400, Cole Robinson wrote: > >> The attached patch logs the the argv's passed to >> the virExec and virRun functions. There's a bit of >> trickery here: since virRun is just a wrapper for >> virExec, we don't want the argv string to

Re: [libvirt] [PATCH 2/3]: Log argv passed to virExec and virRun

2008-11-03 Thread Daniel P. Berrange
On Thu, Oct 30, 2008 at 02:06:20PM -0400, Cole Robinson wrote: > The attached patch logs the the argv's passed to > the virExec and virRun functions. There's a bit of > trickery here: since virRun is just a wrapper for > virExec, we don't want the argv string to be logged > twice. > > I addressed

[libvirt] [PATCH 2/3]: Log argv passed to virExec and virRun

2008-10-30 Thread Cole Robinson
The attached patch logs the the argv's passed to the virExec and virRun functions. There's a bit of trickery here: since virRun is just a wrapper for virExec, we don't want the argv string to be logged twice. I addressed this by renaming virExec to __virExec, and keeping the original function nam