Re: [libvirt] [PATCH 2/3] qemu: use blockjob completed event's error field to detect errors

2016-10-06 Thread Nikolay Shirokovskiy
On 06.10.2016 11:02, Peter Krempa wrote: > On Wed, Oct 05, 2016 at 16:52:09 +0300, Nikolay Shirokovskiy wrote: >> BLOCK_JOB_COMPLETED has error field set on error from day one (12bd451f) >> thus there is no need to guess for error. Is it true that when >> len == offset then can be no error? > >

Re: [libvirt] [PATCH 2/3] qemu: use blockjob completed event's error field to detect errors

2016-10-06 Thread Peter Krempa
On Wed, Oct 05, 2016 at 16:52:09 +0300, Nikolay Shirokovskiy wrote: > BLOCK_JOB_COMPLETED has error field set on error from day one (12bd451f) > thus there is no need to guess for error. Is it true that when > len == offset then can be no error? That is the question you should be able to answer wh

[libvirt] [PATCH 2/3] qemu: use blockjob completed event's error field to detect errors

2016-10-05 Thread Nikolay Shirokovskiy
BLOCK_JOB_COMPLETED has error field set on error from day one (12bd451f) thus there is no need to guess for error. Is it true that when len == offset then can be no error? --- src/qemu/qemu_monitor_json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor