Re: [libvirt] [PATCH 2/3] tests: Use WHEN_BOTH in qemuxml2xml whenever possible

2019-03-05 Thread Ján Tomko
On Fri, Mar 01, 2019 at 04:57:32PM +0100, Andrea Bolognani wrote: Basically I see no reason not to cover both active and inactive when possible, because even when the feature is only going to manifest itself only in one of the two output files, the fact that it does *not* show up in the other one

Re: [libvirt] [PATCH 2/3] tests: Use WHEN_BOTH in qemuxml2xml whenever possible

2019-03-01 Thread Andrea Bolognani
On Fri, 2019-03-01 at 14:59 +0100, Ján Tomko wrote: > On Thu, Feb 28, 2019 at 05:38:46PM +0100, Andrea Bolognani wrote: [...] > > +++ b/tests/qemuxml2xmloutdata/channel-unix-source-path-active.xml > > @@ -22,14 +22,17 @@ > >> function='0x0'/> > > > > > > + > path='/tmp/chann

Re: [libvirt] [PATCH 2/3] tests: Use WHEN_BOTH in qemuxml2xml whenever possible

2019-03-01 Thread Ján Tomko
On Thu, Feb 28, 2019 at 05:38:46PM +0100, Andrea Bolognani wrote: There are a few cases where we are using either WHEN_ACTIVE or WHEN_INACTIVE even though WHEN_BOTH would work perfectly fine: for those, start using the simpler DO_TEST() macro. The goal of those test cases is to test some specif

[libvirt] [PATCH 2/3] tests: Use WHEN_BOTH in qemuxml2xml whenever possible

2019-02-28 Thread Andrea Bolognani
There are a few cases where we are using either WHEN_ACTIVE or WHEN_INACTIVE even though WHEN_BOTH would work perfectly fine: for those, start using the simpler DO_TEST() macro. Signed-off-by: Andrea Bolognani --- ...ource-path.xml => channel-unix-source-path-active.xml} | 3 +++ ...rce-path.xml