Re: [libvirt] [PATCH 2/3] virNetDevMacVLanCreateWithVPortProfile: Drop @rc

2016-08-10 Thread Ján Tomko
On Tue, Aug 09, 2016 at 07:32:44PM +0200, Michal Privoznik wrote: This variable is very misleading. We use VIR_FORCE_CLOSE to set The function is also hard to follow. it to -1 and returning it even though it does not refer to a FD at all. It merely holds 0 or -1. Drop it completely. Yes, i

[libvirt] [PATCH 2/3] virNetDevMacVLanCreateWithVPortProfile: Drop @rc

2016-08-09 Thread Michal Privoznik
This variable is very misleading. We use VIR_FORCE_CLOSE to set it to -1 and returning it even though it does not refer to a FD at all. It merely holds 0 or -1. Drop it completely. Signed-off-by: Michal Privoznik --- src/util/virnetdevmacvlan.c | 35 --- 1 file ch