Re: [libvirt] [PATCH 2/4] Remove unnecessary check for non-NULL uuid

2010-06-21 Thread Jiri Denemark
> We might also get rid of this unnecessary unreferencing and > referencing while touching those 3 memcpys and replace > > memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN); > > with > > memcpy(ret->uuid, uuid, VIR_UUID_BUFLEN); That was my thought too. But since git grep gives about 140 of th

Re: [libvirt] [PATCH 2/4] Remove unnecessary check for non-NULL uuid

2010-06-18 Thread Matthias Bolte
2010/6/17 Jiri Denemark : > The first thing we do in all these functions is to check uuid != NULL > and fail if it isn't. > --- >  src/datatypes.c |   12 >  1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/src/datatypes.c b/src/datatypes.c > index 20b2d74..8750406 1006

[libvirt] [PATCH 2/4] Remove unnecessary check for non-NULL uuid

2010-06-17 Thread Jiri Denemark
The first thing we do in all these functions is to check uuid != NULL and fail if it isn't. --- src/datatypes.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 20b2d74..8750406 100644 --- a/src/datatypes.c +++ b/src/dataty