Re: [libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code"

2019-06-26 Thread Ján Tomko
On Wed, Jun 26, 2019 at 04:54:41PM +0100, Daniel P. Berrangé wrote: This reverts commit 226094fbc483128cf4171c353aed738b8346. A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature

[libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code"

2019-06-26 Thread Daniel P . Berrangé
This reverts commit 226094fbc483128cf4171c353aed738b8346. A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature. A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For f