Re: [libvirt] [PATCH 2/5] libssh2_transport: add main libssh2 transport implementation

2012-08-08 Thread Peter Krempa
On 08/06/12 22:46, Eric Blake wrote: I'm not quite sure how I would test all of the code, but the bulk of it looked sane by just glancing over it. Having not specifically coded with libssh2, I can't say if you were using the library API correctly without spending a lot longer on the review; but

Re: [libvirt] [PATCH 2/5] libssh2_transport: add main libssh2 transport implementation

2012-08-06 Thread Eric Blake
On 08/03/2012 08:03 AM, Peter Krempa wrote: > This patch adds helper functions to libssh2 that enable us to use > libssh2 in conjunction with libvirt-native virNetSockets instead of > using a spawned "ssh" client process. > > This implemetation supports tunneled plaintext, keyboard-interactive, s

[libvirt] [PATCH 2/5] libssh2_transport: add main libssh2 transport implementation

2012-08-03 Thread Peter Krempa
This patch adds helper functions to libssh2 that enable us to use libssh2 in conjunction with libvirt-native virNetSockets instead of using a spawned "ssh" client process. This implemetation supports tunneled plaintext, keyboard-interactive, private key, ssh agent based and null authentication. Li