Re: [libvirt] [PATCH 2/6] conf: Move virDomainDeviceAddressIsValid() to device_conf

2018-09-03 Thread Ján Tomko
On Fri, Aug 31, 2018 at 04:00:43PM +0200, Andrea Bolognani wrote: The function is called on a virDomainDeviceInfo, so it should be declared along with it. Moving this function requires moving and making public virDomainDeviceCCWAddressIsValid() as well, but that's perfectly fine since the same r

[libvirt] [PATCH 2/6] conf: Move virDomainDeviceAddressIsValid() to device_conf

2018-08-31 Thread Andrea Bolognani
The function is called on a virDomainDeviceInfo, so it should be declared along with it. Moving this function requires moving and making public virDomainDeviceCCWAddressIsValid() as well, but that's perfectly fine since the same reasoning above also applies to it, due to virDomainDeviceCCWAddress