Re: [libvirt] [PATCH 2/6] virSecuritySELinuxSetFileconImpl: Drop @optional argument

2019-08-29 Thread Martin Kletzander
On Thu, Aug 22, 2019 at 05:19:05PM +0200, Michal Privoznik wrote: The only thing that the @optional argument does is that it makes the function return 1 instead of 0 if setting SELinux context failed in a non-critical fashion. Drop the argument then and return 1 in that case. This enables caller

[libvirt] [PATCH 2/6] virSecuritySELinuxSetFileconImpl: Drop @optional argument

2019-08-22 Thread Michal Privoznik
The only thing that the @optional argument does is that it makes the function return 1 instead of 0 if setting SELinux context failed in a non-critical fashion. Drop the argument then and return 1 in that case. This enables caller to learn if SELinux context was set or not. Signed-off-by: Michal P