Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-21 Thread Daniel P. Berrange
On Tue, May 21, 2013 at 04:56:37PM +0200, Viktor Mihajlovski wrote: > On 05/20/2013 01:35 PM, Osier Yang wrote: > >>>(!virCgroupHasController(priv->cgroup,VIR_CGROUP_CONTROLLER_MEMORY)) { > >>>+if (vm->def->mem.hard_limit != 0 || > >>>+vm->def->mem.soft_limit != 0 || > >>>+

Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-21 Thread Osier Yang
On 21/05/13 22:56, Viktor Mihajlovski wrote: On 05/20/2013 01:35 PM, Osier Yang wrote: (!virCgroupHasController(priv->cgroup,VIR_CGROUP_CONTROLLER_MEMORY)) { +if (vm->def->mem.hard_limit != 0 || +vm->def->mem.soft_limit != 0 || +vm->def->mem.swap_hard_limit != 0)

Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-21 Thread Viktor Mihajlovski
On 05/20/2013 01:35 PM, Osier Yang wrote: (!virCgroupHasController(priv->cgroup,VIR_CGROUP_CONTROLLER_MEMORY)) { +if (vm->def->mem.hard_limit != 0 || +vm->def->mem.soft_limit != 0 || +vm->def->mem.swap_hard_limit != 0) { +virReportError(VIR_ERR_CONFIG_U

Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-20 Thread Osier Yang
On 20/05/13 19:08, Daniel P. Berrange wrote: On Fri, May 17, 2013 at 07:59:32PM +0800, Osier Yang wrote: --- src/qemu/qemu_cgroup.c | 120 - 1 file changed, 68 insertions(+), 52 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_c

Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-20 Thread Daniel P. Berrange
On Fri, May 17, 2013 at 07:59:32PM +0800, Osier Yang wrote: > --- > src/qemu/qemu_cgroup.c | 120 > - > 1 file changed, 68 insertions(+), 52 deletions(-) > > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c > index 0c4792e..2751be0 1006

[libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

2013-05-17 Thread Osier Yang
--- src/qemu/qemu_cgroup.c | 120 - 1 file changed, 68 insertions(+), 52 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 0c4792e..2751be0 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -455,6 +455