Re: [libvirt] [PATCH 2/9] Extend element with controller information

2009-09-25 Thread Daniel P. Berrange
On Thu, Sep 24, 2009 at 11:39:08PM +0200, Matthias Bolte wrote: > 2009/9/24 Daniel P. Berrange : > > > > Outside the scope of your patches, I think it would be > > worth adding a 'name' attribute to all devices in the > > libvirt XML as a standardized unique identifier. We > > already have to keep

Re: [libvirt] [PATCH 2/9] Extend element with controller information

2009-09-25 Thread Wolfgang Mauerer
Matthias Bolte wrote: > 2009/9/24 Daniel P. Berrange : >> Outside the scope of your patches, I think it would be >> worth adding a 'name' attribute to all devices in the >> libvirt XML as a standardized unique identifier. We >> already have to keep track of a 'name' internally for >> NIC hotplug wi

Re: [libvirt] [PATCH 2/9] Extend element with controller information

2009-09-25 Thread Wolfgang Mauerer
Daniel P. Berrange wrote: > On Fri, Sep 18, 2009 at 05:26:09PM +0200, Wolfgang Mauerer wrote: >> This allows us to connect a disk with a specific controller, >> which is required for disk hotadd/remove. A new XML child >> element is added to the container: >> >> >> ... >> > unit=""/> >> >>

Re: [libvirt] [PATCH 2/9] Extend element with controller information

2009-09-24 Thread Matthias Bolte
2009/9/24 Daniel P. Berrange : > > Outside the scope of your patches, I think it would be > worth adding a 'name' attribute to all devices in the > libvirt XML as a standardized unique identifier. We > already have to keep track of a 'name' internally for > NIC hotplug with QEMU, and with QEMU's qd

Re: [libvirt] [PATCH 2/9] Extend element with controller information

2009-09-24 Thread Daniel P. Berrange
On Fri, Sep 18, 2009 at 05:26:09PM +0200, Wolfgang Mauerer wrote: > This allows us to connect a disk with a specific controller, > which is required for disk hotadd/remove. A new XML child > element is added to the container: > > > ... >unit=""/> > > > Either id _or_ pci_addr can be sp

[libvirt] [PATCH 2/9] Extend element with controller information

2009-09-18 Thread Wolfgang Mauerer
This allows us to connect a disk with a specific controller, which is required for disk hotadd/remove. A new XML child element is added to the container: ... Either id _or_ pci_addr can be specified. When the controller has been brought into the system via tghe hotplug mechanism also