Re: [libvirt] [PATCH 2/9] tests: qemuxml2xml: Always use different output file

2016-02-09 Thread Cole Robinson
On 02/08/2016 10:27 AM, Martin Kletzander wrote: > > I didn't mean to stall this series. I'm fine with this going in, > especially if we clean it up afterwards. > No worries, the bits you raised are valid concerns. > So if you also copy the missing files, of course (current list of test > name

Re: [libvirt] [PATCH 2/9] tests: qemuxml2xml: Always use different output file

2016-02-08 Thread Martin Kletzander
On Fri, Feb 05, 2016 at 03:37:59PM -0500, Cole Robinson wrote: On 02/05/2016 02:24 PM, Laine Stump wrote: On 01/28/2016 03:30 PM, Cole Robinson wrote: Most qemuxml2xml tests expect that the input XML is unchanged after parsing. This is unlike 99% of new qemu configs in the wild, which after ini

Re: [libvirt] [PATCH 2/9] tests: qemuxml2xml: Always use different output file

2016-02-05 Thread Cole Robinson
On 02/05/2016 02:24 PM, Laine Stump wrote: > On 01/28/2016 03:30 PM, Cole Robinson wrote: >> Most qemuxml2xml tests expect that the input XML is unchanged after >> parsing. This is unlike 99% of new qemu configs in the wild, which after >> initial parsing end up with stable PCI device addresses. Th

Re: [libvirt] [PATCH 2/9] tests: qemuxml2xml: Always use different output file

2016-02-05 Thread Laine Stump
On 01/28/2016 03:30 PM, Cole Robinson wrote: Most qemuxml2xml tests expect that the input XML is unchanged after parsing. This is unlike 99% of new qemu configs in the wild, which after initial parsing end up with stable PCI device addresses. The xml2xml bit doesn't currently hit that code path t