Re: [libvirt] [PATCH 20/21] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

2019-03-21 Thread Cole Robinson
On 3/19/19 11:18 AM, Andrea Bolognani wrote: > On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: > [...] >> @@ -612,20 +614,25 @@ typedef enum { >> ARG_MIGRATE_FD, >> ARG_FLAGS, >> ARG_PARSEFLAGS, >> +ARG_CAPS_ARCH, >> +ARG_CAPS_VER, > > I guess these could be simply A

Re: [libvirt] [PATCH 20/21] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

2019-03-19 Thread Andrea Bolognani
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote: [...] > @@ -612,20 +614,25 @@ typedef enum { > ARG_MIGRATE_FD, > ARG_FLAGS, > ARG_PARSEFLAGS, > +ARG_CAPS_ARCH, > +ARG_CAPS_VER, I guess these could be simply ARG_ARCH and ARG_VER, but I don't have a terribly strong opi

[libvirt] [PATCH 20/21] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

2019-03-14 Thread Cole Robinson
Move DO_CAPS_TEST* qemuCaps init and all the associated setup into testInfoSetArgs, adding ARG_CAPS_ARCH and ARG_CAPS_VER options and using those to build the capsfile path locally Signed-off-by: Cole Robinson --- tests/qemuxml2argvtest.c | 68 +++- 1 file cha