Re: [libvirt] [PATCH 3/3] lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away

2014-07-08 Thread Eric Blake
On 07/08/2014 09:53 AM, Eric Blake wrote: >> +if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE && !base) { >> +virReportInvalidArg(base, "%s", >> +_("flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is >> valid " >> + "only with non-null base"

Re: [libvirt] [PATCH 3/3] lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away

2014-07-08 Thread Eric Blake
On 07/08/2014 09:29 AM, Peter Krempa wrote: > VIR_DOMAIN_BLOCK_REBASE_RELATIVE works only when @base is specified. > Check it right in libvirt.c as it's not expected to change across > hypervisors. > --- > src/libvirt.c | 7 +++ > src/qemu/qemu_driver.c | 7 --- > 2 files changed,

[libvirt] [PATCH 3/3] lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away

2014-07-08 Thread Peter Krempa
VIR_DOMAIN_BLOCK_REBASE_RELATIVE works only when @base is specified. Check it right in libvirt.c as it's not expected to change across hypervisors. --- src/libvirt.c | 7 +++ src/qemu/qemu_driver.c | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libvirt