Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-16 Thread Andrea Bolognani
On Mon, 2018-01-15 at 18:51 +0100, Michal Privoznik wrote: > > At least FreeBSD ships it, though: > > > > # pkg list readline | grep pc$ > > /usr/local/libdata/pkgconfig/readline.pc > > is this GNU readline? I've heard that FreeBSD is ditching GNU software. FreeBSD (starting with version 11)

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Michal Privoznik
On 01/15/2018 05:39 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 16:36 +0100, Michal Privoznik wrote: >>> So, one way to solve this once and for all would be to: >>> >>> * try looking up readline through pkg-config. If that works, >>> then we already know we're compiling against a rece

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Andrea Bolognani
On Mon, 2018-01-15 at 16:36 +0100, Michal Privoznik wrote: > > So, one way to solve this once and for all would be to: > > > > * try looking up readline through pkg-config. If that works, > > then we already know we're compiling against a recent > > readline version and everything will w

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Michal Privoznik
On 01/15/2018 12:30 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: >> macOS has brew, though. I've kicked off a Travis build with this >> commit[1] included, let's see whether configure picks up readline >> installed from brew instead of the obsolete one av

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 02:20:01PM +0100, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote: > > > So, one way to solve this once and for all would be to: > > > > > > * try looking up readline through pkg-config. If that works, > > > then we already know we'

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Andrea Bolognani
On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote: > > So, one way to solve this once and for all would be to: > > > > * try looking up readline through pkg-config. If that works, > > then we already know we're compiling against a recent > > readline version and everything will w

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Michal Privoznik
On 01/15/2018 12:30 PM, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: >> macOS has brew, though. I've kicked off a Travis build with this >> commit[1] included, let's see whether configure picks up readline >> installed from brew instead of the obsolete one av

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Andrea Bolognani
On Mon, 2018-01-15 at 10:26 +0100, Andrea Bolognani wrote: > macOS has brew, though. I've kicked off a Travis build with this > commit[1] included, let's see whether configure picks up readline > installed from brew instead of the obsolete one available in the > base system. Nope, it still picks u

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-15 Thread Andrea Bolognani
On Sun, 2018-01-14 at 14:46 +0100, Michal Privoznik wrote: > Apparently we can't assume that people run readline recent enough > to have rl_completion_quote_character (added in readline-5.0 > released in 2011). However, we can't compile without it. So if > not present, disable readline. > > Signed

[libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-14 Thread Michal Privoznik
Apparently we can't assume that people run readline recent enough to have rl_completion_quote_character (added in readline-5.0 released in 2011). However, we can't compile without it. So if not present, disable readline. Signed-off-by: Michal Privoznik --- Frankly, I hate this patch. How far int