Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 4:19 PM Michal Privoznik wrote: > > On 6/19/19 4:04 PM, Ilias Stamatis wrote: > > On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik > > wrote: > >> > >> On 6/19/19 1:18 PM, Ilias Stamatis wrote: > >>> testDomainInterfaceAddresses always returns the same hard-coded > >>> ad

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Michal Privoznik
On 6/19/19 4:04 PM, Ilias Stamatis wrote: > On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: >> >> On 6/19/19 1:18 PM, Ilias Stamatis wrote: >>> testDomainInterfaceAddresses always returns the same hard-coded >>> addresses. Change the behavior such as if there is a DHCP range defined, >>> a

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: > > On 6/19/19 1:18 PM, Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > > addresses. Change the behavior such as if there is a DHCP range defined, > > addresses are returned from that pool. > > > >

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ján Tomko
On Wed, Jun 19, 2019 at 03:47:58PM +0200, Michal Privoznik wrote: On 6/19/19 1:18 PM, Ilias Stamatis wrote: [...] @@ -3413,6 +3426,16 @@ testDomainInterfaceAddresses(virDomainPtr dom, if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK) continue; +virObjec

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Michal Privoznik
On 6/19/19 1:18 PM, Ilias Stamatis wrote: testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific g

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 1:19 PM Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > addresses. Change the behavior such as if there is a DHCP range defined, > addresses are returned from that pool. > > The specific address returned depends on both the domain

[libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific guest interface in an attempt to return uniqu