Re: [libvirt] [PATCH 3/3] virsh: Use virNodeGetCPUMap if possible

2012-10-31 Thread Viktor Mihajlovski
On 10/31/2012 02:30 AM, Eric Blake wrote: This looks correct. However, it may be easier to write a helper function vshGetCPUCount, rather than copying and pasting this code into multiple places. I'm okay giving this an ACK, but since I've already asked for a v2 of patch 1, you might want to do

Re: [libvirt] [PATCH 3/3] virsh: Use virNodeGetCPUMap if possible

2012-10-30 Thread Eric Blake
On 10/26/2012 07:19 AM, Viktor Mihajlovski wrote: > Modified the places where virNodeGetInfo was used for the purpose > of obtaining the maximum node CPU number. Transparently falling > back to virNodeGetInfo in case of failure. > > Signed-off-by: Viktor Mihajlovski > --- > tools/virsh-domain.c

[libvirt] [PATCH 3/3] virsh: Use virNodeGetCPUMap if possible

2012-10-26 Thread Viktor Mihajlovski
Modified the places where virNodeGetInfo was used for the purpose of obtaining the maximum node CPU number. Transparently falling back to virNodeGetInfo in case of failure. Signed-off-by: Viktor Mihajlovski --- tools/virsh-domain.c | 36 1 file changed, 24 in