Re: [libvirt] [PATCH 3/3] virsh: add --paused option to create

2010-06-08 Thread Eric Blake
On 06/08/2010 02:57 PM, Jiri Denemark wrote: >> +unsigned int paused = (vshCommandOptBool(cmd, "paused") >> + ? VIR_DOMAIN_START_PAUSED >> + : VIR_DOMAIN_NONE); > > I'd probably name this variable "flags" to avoid confusion (or the need to >

Re: [libvirt] [PATCH 3/3] virsh: add --paused option to create

2010-06-08 Thread Jiri Denemark
> diff --git a/tools/virsh.c b/tools/virsh.c > index 1279f41..6b05949 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -1141,6 +1141,7 @@ static const vshCmdOptDef opts_create[] = { > #ifndef WIN32 > {"console", VSH_OT_BOOL, 0, N_("attach to console after creation")}, > #endif > +

[libvirt] [PATCH 3/3] virsh: add --paused option to create

2010-06-08 Thread Eric Blake
* tools/virsh.c (opts_create): Add --paused option. (cmdCreate): Pass appropriate flag. * tools/virsh.pod: Document it. --- I'm following my own review advice of documenting changes in virsh.pod as I make them :) tools/virsh.c |6 +- tools/virsh.pod |6 -- 2 files changed, 9 in