Re: [libvirt] [PATCH 3/4] snapshot: expose location through virsh snapshot-info

2012-11-19 Thread Peter Krempa
On 11/15/12 00:20, Eric Blake wrote: On 11/14/2012 11:43 AM, Eric Blake wrote: Bleah. Raw XML parsing. Wouldn't it be easier in and cleaner convert this piece code to use the XML parser and xpath? Not the first time we've done this. I agree that using the XML parser and xpath is probably nice

Re: [libvirt] [PATCH 3/4] snapshot: expose location through virsh snapshot-info

2012-11-14 Thread Eric Blake
On 11/14/2012 11:43 AM, Eric Blake wrote: >> Bleah. Raw XML parsing. Wouldn't it be easier in and cleaner convert >> this piece code to use the XML parser and xpath? > > Not the first time we've done this. I agree that using the XML parser > and xpath is probably nicer, but it actually takes more

Re: [libvirt] [PATCH 3/4] snapshot: expose location through virsh snapshot-info

2012-11-14 Thread Eric Blake
On 11/13/2012 05:16 PM, Peter Krempa wrote: > On 11/13/12 20:09, Eric Blake wrote: >> Now that we can filter on this information, we should also make >> it easy to get at. >> >> * tools/virsh-snapshot.c (cmdSnapshotInfo): Add another output >> row. >> --- >> tools/virsh-snapshot.c | 32 ++

Re: [libvirt] [PATCH 3/4] snapshot: expose location through virsh snapshot-info

2012-11-13 Thread Peter Krempa
On 11/13/12 20:09, Eric Blake wrote: Now that we can filter on this information, we should also make it easy to get at. * tools/virsh-snapshot.c (cmdSnapshotInfo): Add another output row. --- tools/virsh-snapshot.c | 32 +++- 1 file changed, 27 insertions(+), 5 del

[libvirt] [PATCH 3/4] snapshot: expose location through virsh snapshot-info

2012-11-13 Thread Eric Blake
Now that we can filter on this information, we should also make it easy to get at. * tools/virsh-snapshot.c (cmdSnapshotInfo): Add another output row. --- tools/virsh-snapshot.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/tools/virsh-snaps