Re: [libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-10 Thread Erik Skultety
On Thu, Jan 10, 2019 at 11:42:08AM -0500, Laine Stump wrote: > On 1/10/19 10:38 AM, Erik Skultety wrote: > > On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote: > > > On 1/10/19 9:09 AM, Erik Skultety wrote: > > > > On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote: > > > > > Thi

Re: [libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-10 Thread Laine Stump
On 1/10/19 10:38 AM, Erik Skultety wrote: On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote: On 1/10/19 9:09 AM, Erik Skultety wrote: On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote: This is about the same number of code lines, but is simpler, and more consistent with wha

Re: [libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-10 Thread Erik Skultety
On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote: > On 1/10/19 9:09 AM, Erik Skultety wrote: > > On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote: > > > This is about the same number of code lines, but is simpler, and more > > > consistent with what will be added to check anot

Re: [libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-10 Thread Laine Stump
On 1/10/19 9:09 AM, Erik Skultety wrote: On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote: This is about the same number of code lines, but is simpler, and more consistent with what will be added to check another attribute in a coming patch. As a side effect, it Resolves: https://bu

Re: [libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-10 Thread Erik Skultety
On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote: > This is about the same number of code lines, but is simpler, and more > consistent with what will be added to check another attribute in a > coming patch. > > As a side effect, it > > Resolves: https://bugzilla.redhat.com/1583131 > Sign

[libvirt] [PATCH 3/4] util: use nlmsg_find_attr() instead of an open-coded loop

2019-01-09 Thread Laine Stump
This is about the same number of code lines, but is simpler, and more consistent with what will be added to check another attribute in a coming patch. As a side effect, it Resolves: https://bugzilla.redhat.com/1583131 Signed-off-by: Laine Stump --- src/util/virnetdevip.c | 53 ++