Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-20 Thread Guido Günther
On Thu, Dec 18, 2008 at 03:53:17PM +0100, Guido Günther wrote: > On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote: > > No, not guarenteed to be safe because the 'config_xml' string could > > contain '%' sequences that'll be interpreted by sprintf. In any case > > why not just use

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-18 Thread Guido Günther
On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote: > No, not guarenteed to be safe because the 'config_xml' string could > contain '%' sequences that'll be interpreted by sprintf. In any case > why not just use > >virBufferAdd(&buf, config_xml) Updated version using virBuffer

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-18 Thread Daniel P. Berrange
On Thu, Dec 18, 2008 at 10:34:03AM +0100, Guido G?nther wrote: > On Mon, Dec 15, 2008 at 10:25:27AM +0100, Daniel Veillard wrote: > > On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido Günther wrote: > > > Functions to read and write vm status in $(statedir)/qemu/.xml. > > > Keeps the necessary to rec

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-18 Thread Guido Günther
On Mon, Dec 15, 2008 at 10:25:27AM +0100, Daniel Veillard wrote: > On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido Günther wrote: > > Functions to read and write vm status in $(statedir)/qemu/.xml. > > Keeps the necessary to reconnect to a running domain state within > > I kept most of the cod

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-15 Thread Daniel P. Berrange
On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido G?nther wrote: > Functions to read and write vm status in $(statedir)/qemu/.xml. > Keeps the necessary to reconnect to a running domain state within > I kept most of the code in qemu_config.c for > now. We can easily move it should another hyperv

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-15 Thread Daniel Veillard
On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido Günther wrote: > Functions to read and write vm status in $(statedir)/qemu/.xml. > Keeps the necessary to reconnect to a running domain state within > I kept most of the code in qemu_config.c for > now. We can easily move it should another hyperv

[libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-12 Thread Guido Günther
Functions to read and write vm status in $(statedir)/qemu/.xml. Keeps the necessary to reconnect to a running domain state within I kept most of the code in qemu_config.c for now. We can easily move it should another hypervisor need to do something similar. --- src/domain_conf.c |