On Wed, Nov 15, 2017 at 05:59:39PM -0500, John Ferlan wrote:
>
>
> On 11/14/2017 09:17 AM, Erik Skultety wrote:
> > On Sun, Nov 12, 2017 at 09:46:48AM -0500, John Ferlan wrote:
> >>
> >> [...]
> >>
> >>> Now the actual review.
> >>> virNetDaemonAddServer is only used when spawning a new daemon or s
On 11/14/2017 09:17 AM, Erik Skultety wrote:
> On Sun, Nov 12, 2017 at 09:46:48AM -0500, John Ferlan wrote:
>>
>> [...]
>>
>>> Now the actual review.
>>> virNetDaemonAddServer is only used when spawning a new daemon or setting up
>>> LXC
>>> controller. The function essentially does:
>>>
>>> loc
On Sun, Nov 12, 2017 at 09:46:48AM -0500, John Ferlan wrote:
>
> [...]
>
> > Now the actual review.
> > virNetDaemonAddServer is only used when spawning a new daemon or setting up
> > LXC
> > controller. The function essentially does:
> >
> > lock(@dmn)
> > hash_table_add(@srv)
> > ref(@sr
On Fri, Nov 10, 2017 at 05:41:51PM -0500, John Ferlan wrote:
>
>
> On 11/10/2017 10:08 AM, Erik Skultety wrote:
> > On Tue, Nov 07, 2017 at 09:39:54PM -0500, John Ferlan wrote:
> >> Whether the @srv/@srvAdm is added to the dmn->servers list or not,
> >> the reference kept for the allocation can be
[...]
> Now the actual review.
> virNetDaemonAddServer is only used when spawning a new daemon or setting up
> LXC
> controller. The function essentially does:
>
> lock(@dmn)
> hash_table_add(@srv)
> ref(@srv)
> unlock(@dmn)
>
> and then you unref @dmn right upon the completion of addi
On 11/10/2017 10:08 AM, Erik Skultety wrote:
> On Tue, Nov 07, 2017 at 09:39:54PM -0500, John Ferlan wrote:
>> Whether the @srv/@srvAdm is added to the dmn->servers list or not,
>> the reference kept for the allocation can be dropped leaving just the
>> reference for being on the dmn->servers lis
On Tue, Nov 07, 2017 at 09:39:54PM -0500, John Ferlan wrote:
> Whether the @srv/@srvAdm is added to the dmn->servers list or not,
> the reference kept for the allocation can be dropped leaving just the
> reference for being on the dmn->servers list be the sole deciding
> factor when to really free
Whether the @srv/@srvAdm is added to the dmn->servers list or not,
the reference kept for the allocation can be dropped leaving just the
reference for being on the dmn->servers list be the sole deciding
factor when to really free the associated memory. The @dmn dispose
function (virNetDaemonDispose
