Re: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-13 Thread Peter Krempa
On Wed, Mar 13, 2019 at 10:32:59 +0100, Andrea Bolognani wrote: > On Wed, 2019-03-13 at 10:22 +0100, Peter Krempa wrote: > > On Wed, Mar 13, 2019 at 10:18:52 +0100, Andrea Bolognani wrote: > > > Anyway, by the end of the series we'll have to pass dataDir to > > > testQemuCapsIterate() in addition t

Re: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-13 Thread Andrea Bolognani
On Wed, 2019-03-13 at 10:22 +0100, Peter Krempa wrote: > On Wed, Mar 13, 2019 at 10:18:52 +0100, Andrea Bolognani wrote: > > Anyway, by the end of the series we'll have to pass dataDir to > > testQemuCapsIterate() in addition to using it to build the path for > > both the input and output file, so

Re: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-13 Thread Peter Krempa
On Wed, Mar 13, 2019 at 10:18:52 +0100, Andrea Bolognani wrote: > On Wed, 2019-03-13 at 09:41 +0100, Peter Krempa wrote: > > On Thu, Mar 07, 2019 at 16:44:32 +0100, Andrea Bolognani wrote: > > > This removes a little duplication right away, and more > > > importantly will allow us to perform some i

Re: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-13 Thread Andrea Bolognani
On Wed, 2019-03-13 at 09:41 +0100, Peter Krempa wrote: > On Thu, Mar 07, 2019 at 16:44:32 +0100, Andrea Bolognani wrote: > > This removes a little duplication right away, and more > > importantly will allow us to perform some interesting > > refactoring later on. [...] > > @@ -47,6 +48,8 @@ testQem

Re: [libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-13 Thread Peter Krempa
On Thu, Mar 07, 2019 at 16:44:32 +0100, Andrea Bolognani wrote: > This removes a little duplication right away, and more > importantly will allow us to perform some interesting > refactoring later on. > > Signed-off-by: Andrea Bolognani > --- > tests/qemucapabilitiestest.c | 15 +-- >

[libvirt] [PATCH 3/8] tests: Move data directories into testQemuData

2019-03-07 Thread Andrea Bolognani
This removes a little duplication right away, and more importantly will allow us to perform some interesting refactoring later on. Signed-off-by: Andrea Bolognani --- tests/qemucapabilitiestest.c | 15 +-- tests/qemucaps2xmltest.c | 13 + 2 files changed, 18 insertion