Re: [libvirt] [PATCH 3/9] tests: qemuxml2xml: Fix disk-mirror

2016-08-04 Thread Ján Tomko
It's not really broken. Maybe s/Fix/clean up/? On Fri, Jul 29, 2016 at 07:46:23PM +0200, Andrea Bolognani wrote: Instead of testing it twice using WHEN_ACTIVE and WHEN_INACTIVE separately, just use WHEN_BOTH. --- tests/qemuxml2xmltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[libvirt] [PATCH 3/9] tests: qemuxml2xml: Fix disk-mirror

2016-07-29 Thread Andrea Bolognani
Instead of testing it twice using WHEN_ACTIVE and WHEN_INACTIVE separately, just use WHEN_BOTH. --- tests/qemuxml2xmltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 5f04b8b..2af8245 100644 --- a/tests/qemuxml2xmlt