Re: [libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

2015-10-14 Thread Peter Krempa
On Tue, Oct 13, 2015 at 13:54:54 -0400, John Ferlan wrote: > On 10/13/2015 12:29 PM, Peter Krempa wrote: > > On Tue, Oct 13, 2015 at 11:47:10 -0400, John Ferlan wrote: ... > >> @@ -2341,15 +2343,49 @@ virDomainIOThreadIDDefArrayInit(virDomainDefPtr > >> def) > >> if (def->iothreads == def->

Re: [libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

2015-10-13 Thread John Ferlan
On 10/13/2015 12:29 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:10 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1264008 >> >> The existing algorithm assumed that someone was making small, incremental >> changes; however, it is possible to change iothreads f

Re: [libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

2015-10-13 Thread Peter Krempa
On Tue, Oct 13, 2015 at 11:47:10 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1264008 > > The existing algorithm assumed that someone was making small, incremental > changes; however, it is possible to change iothreads from 0 (or relatively > small number) to some really

[libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

2015-10-13 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1264008 The existing algorithm assumed that someone was making small, incremental changes; however, it is possible to change iothreads from 0 (or relatively small number) to some really large number and the algorithm would possibly spin its wheels doing