Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
On 10/06/2014 08:44 AM, Ján Tomko wrote: > On 10/06/2014 01:23 PM, John Ferlan wrote: <...snip...> >> >> If you mean we don't check that the name starts with 'scsi' or >> 'scsi_host', then sure I agree, but that would be a different bug or >> issue. I can certainly add a check if that's desire

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread Ján Tomko
On 10/06/2014 01:23 PM, John Ferlan wrote: > > > On 10/03/2014 09:20 AM, Ján Tomko wrote: >> On 09/30/2014 11:35 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1146837 >>> >>> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) >>> which added parentadd

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
On 10/03/2014 09:20 AM, Ján Tomko wrote: > On 09/30/2014 11:35 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1146837 >> >> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) >> which added parentaddr and unique_id to allow unique identification of >> a

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-03 Thread Ján Tomko
On 09/30/2014 11:35 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1146837 > > Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) > which added parentaddr and unique_id to allow unique identification of > a scsi_host, but assumed that all the pool entries

[libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-09-30 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1146837 Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) which added parentaddr and unique_id to allow unique identification of a scsi_host, but assumed that all the pool entries and the incoming definition would be similarly defin