Re: [libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest

2018-08-28 Thread Andrea Bolognani
On Mon, 2018-08-27 at 18:09 +0200, Peter Krempa wrote: > 'metadata' and 'leases' are features internal to libvirt and thus don't > influence the XML. As they are not tested we don't need the output > files. I think you meant s/XML/generated QEMU command line/ here? -- Andrea Bolognani / Red Hat

Re: [libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest

2018-08-27 Thread Erik Skultety
On Mon, Aug 27, 2018 at 06:09:09PM +0200, Peter Krempa wrote: > 'metadata' and 'leases' are features internal to libvirt and thus don't > influence the XML. As they are not tested we don't need the output > files. > > Signed-off-by: Peter Krempa > --- Reviewed-by: Erik Skultety -- libvir-list ma

[libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest

2018-08-27 Thread Peter Krempa
'metadata' and 'leases' are features internal to libvirt and thus don't influence the XML. As they are not tested we don't need the output files. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/lease.args| 23 --- tests/qemuxml2argvdata/metadata.args | 22 -