Re: [libvirt] [PATCH 4/5] conf: track more fields in backing chain metadata

2014-04-04 Thread Peter Krempa
On 04/04/14 14:54, Eric Blake wrote: > On 04/04/2014 03:31 AM, Peter Krempa wrote: > >>> struct _virStorageFileMetadata { >>> -char *backingStore; /* Canonical name (absolute file, or protocol) */ >>> -char *backingStoreRaw; /* If file, original name, possibly relative */ >>> -char *d

Re: [libvirt] [PATCH 4/5] conf: track more fields in backing chain metadata

2014-04-04 Thread Eric Blake
On 04/04/2014 03:31 AM, Peter Krempa wrote: >> struct _virStorageFileMetadata { >> -char *backingStore; /* Canonical name (absolute file, or protocol) */ >> -char *backingStoreRaw; /* If file, original name, possibly relative */ >> -char *directory; /* The directory containing basenam

Re: [libvirt] [PATCH 4/5] conf: track more fields in backing chain metadata

2014-04-04 Thread Peter Krempa
On 04/04/14 06:32, Eric Blake wrote: > The current use of virStorageFileMetadata is awkward; to learn > some of the information about a child node, you have to read > fields in the parent node. This does not lend itself well to > modifying backing chains (whether inserting a new node in the > chai

[libvirt] [PATCH 4/5] conf: track more fields in backing chain metadata

2014-04-03 Thread Eric Blake
The current use of virStorageFileMetadata is awkward; to learn some of the information about a child node, you have to read fields in the parent node. This does not lend itself well to modifying backing chains (whether inserting a new node in the chain, or consolidating existing nodes); better wou