Re: [libvirt] [PATCH 4/6] qemu: Refactor do{Tunnel, Native}Migrate functions

2011-08-15 Thread Jiri Denemark
On Mon, Aug 15, 2011 at 17:48:03 +0800, Daniel Veillard wrote: > On Mon, Aug 15, 2011 at 09:58:14AM +0200, Jiri Denemark wrote: > > The core of these two functions is very similar and most of it is even > > exactly the same. Factor out the core functionality into a separate > > function to remove c

Re: [libvirt] [PATCH 4/6] qemu: Refactor do{Tunnel, Native}Migrate functions

2011-08-15 Thread Daniel Veillard
On Mon, Aug 15, 2011 at 09:58:14AM +0200, Jiri Denemark wrote: > The core of these two functions is very similar and most of it is even > exactly the same. Factor out the core functionality into a separate > function to remove code duplication and make further changes easier. > --- > src/qemu/qemu

[libvirt] [PATCH 4/6] qemu: Refactor do{Tunnel, Native}Migrate functions

2011-08-15 Thread Jiri Denemark
The core of these two functions is very similar and most of it is even exactly the same. Factor out the core functionality into a separate function to remove code duplication and make further changes easier. --- src/qemu/qemu_migration.c | 499 ++--- 1 file