Re: [libvirt] [PATCH 4/6] tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev

2016-10-06 Thread Peter Krempa
On Wed, Oct 05, 2016 at 09:38:16 -0400, John Ferlan wrote: > On 09/27/2016 12:39 PM, Peter Krempa wrote: > > Until now the test was rather useless since it didn't check the > > arguments formatted and didn't use properly configured chardev objects. > > > > Add the expected arguments and instrument

Re: [libvirt] [PATCH 4/6] tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev

2016-10-05 Thread John Ferlan
On 09/27/2016 12:39 PM, Peter Krempa wrote: > Until now the test was rather useless since it didn't check the > arguments formatted and didn't use properly configured chardev objects. > > Add the expected arguments and instrument the test to validate them. > Modify some test cases to actually ad

[libvirt] [PATCH 4/6] tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev

2016-09-27 Thread Peter Krempa
Until now the test was rather useless since it didn't check the arguments formatted and didn't use properly configured chardev objects. Add the expected arguments and instrument the test to validate them. Modify some test cases to actually add valid data. Note that the UDP test data is currently