Re: [libvirt] [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

2018-05-23 Thread Ján Tomko
On Wed, May 23, 2018 at 03:04:47PM +0200, Peter Krempa wrote: On Tue, May 22, 2018 at 15:24:06 +0200, Ján Tomko wrote: On Tue, May 22, 2018 at 02:35:44PM +0200, Peter Krempa wrote: > Monitor is now JSON only. Drop the old cruft. > In theory, you should still be able to get a domain with a text

Re: [libvirt] [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

2018-05-23 Thread Peter Krempa
On Tue, May 22, 2018 at 15:24:06 +0200, Ján Tomko wrote: > On Tue, May 22, 2018 at 02:35:44PM +0200, Peter Krempa wrote: > > Monitor is now JSON only. Drop the old cruft. > > > > In theory, you should still be able to get a domain with a text monitor > via qemu-attach. > > In practice, attaching

Re: [libvirt] [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

2018-05-22 Thread Ján Tomko
On Tue, May 22, 2018 at 02:35:44PM +0200, Peter Krempa wrote: Monitor is now JSON only. Drop the old cruft. In theory, you should still be able to get a domain with a text monitor via qemu-attach. In practice, attaching to such domains seems pointless - if we don't support starting them, touc

[libvirt] [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

2018-05-22 Thread Peter Krempa
Monitor is now JSON only. Drop the old cruft. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 138 ++-- 1 file changed, 63 insertions(+), 75 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 3e87bf5a4a..9d6659