Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 01:22:41PM -0700, Eric Blake wrote: > On 02/18/2011 12:30 PM, Jim Meyering wrote: > >>> -if (doms->objs) > >>> -virHashFree(doms->objs, virDomainObjListDeallocator); > >>> +virHashFree(doms->objs, virDomainObjListDeallocator); > >> > >> I tried adding --name=

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-18 Thread Eric Blake
On 02/18/2011 12:30 PM, Jim Meyering wrote: >>> -if (doms->objs) >>> -virHashFree(doms->objs, virDomainObjListDeallocator); >>> +virHashFree(doms->objs, virDomainObjListDeallocator); >> >> I tried adding --name=virHashFree to the useless_free_options variable >> in cfg.mk, to see if

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-18 Thread Jim Meyering
Eric Blake wrote: > [adding Jim to cc, as author of useless-if-before-free] > > On 02/17/2011 02:14 PM, Christophe Fergeau wrote: >> virHashFree follows the convention described in HACKING that >> XXXFree() functions can be called with a NULL argument. >> --- >> src/conf/domain_conf.c |6 +---

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-17 Thread Eric Blake
[adding Jim to cc, as author of useless-if-before-free] On 02/17/2011 02:14 PM, Christophe Fergeau wrote: > virHashFree follows the convention described in HACKING that > XXXFree() functions can be called with a NULL argument. > --- > src/conf/domain_conf.c |6 +--- > src/datatypes.c

[libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-17 Thread Christophe Fergeau
virHashFree follows the convention described in HACKING that XXXFree() functions can be called with a NULL argument. --- src/conf/domain_conf.c |6 +--- src/datatypes.c | 51 +++--- src/qemu/qemu_process.c |4 +-- 3 files changed, 20 inser