Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Richard W.M. Jones
I should maybe add that if you're going to do this, you should think about having a single generator program. There's nothing worse for maintainability than having scripts generating files generating files generating code, and no one can tell what generates what. In libguestfs there's never a que

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2011 at 04:32:57PM +0100, Daniel P. Berrange wrote: > Yeah, either we duplicate the VIR_CONNECT_RO flag checks in > the remote dispatch, or we could actually generate the libvirt.c > and driver.h files too, based on the RPC. More code generation is better. Here is all the code y

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Matthias Bolte
2011/5/10 Daniel P. Berrange : > On Tue, May 10, 2011 at 05:23:23PM +0200, Matthias Bolte wrote: >> 2011/5/10 Daniel P. Berrange : >> > On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: >> >> On 05/07/2011 06:28 AM, Matthias Bolte wrote: >> >> > --- >> >> >  daemon/Makefile.am            

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 05:23:23PM +0200, Matthias Bolte wrote: > 2011/5/10 Daniel P. Berrange : > > On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: > >> On 05/07/2011 06:28 AM, Matthias Bolte wrote: > >> > --- > >> >  daemon/Makefile.am                 |   20 - > >> >  daemon/qemu_

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Matthias Bolte
2011/5/10 Daniel P. Berrange : > On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: >> On 05/07/2011 06:28 AM, Matthias Bolte wrote: >> > --- >> >  daemon/Makefile.am                 |   20 - >> >  daemon/qemu_dispatch.blacklist     |    3 + >> >  daemon/qemu_dispatch.whitelist     |  

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-10 Thread Daniel P. Berrange
On Mon, May 09, 2011 at 03:45:29PM -0600, Eric Blake wrote: > On 05/07/2011 06:28 AM, Matthias Bolte wrote: > > --- > > daemon/Makefile.am | 20 - > > daemon/qemu_dispatch.blacklist |3 + > > daemon/qemu_dispatch.whitelist |1 + > > daemon/remote_dispatch.blac

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-09 Thread Matthias Bolte
2011/5/9 Eric Blake : > On 05/07/2011 06:28 AM, Matthias Bolte wrote: >> --- >>  daemon/Makefile.am                 |   20 - >>  daemon/qemu_dispatch.blacklist     |    3 + >>  daemon/qemu_dispatch.whitelist     |    1 + >>  daemon/remote_dispatch.blacklist   |   37 >>  daemon/remote_d

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: > --- > daemon/Makefile.am | 20 - > daemon/qemu_dispatch.blacklist |3 + > daemon/qemu_dispatch.whitelist |1 + > daemon/remote_dispatch.blacklist | 37 > daemon/remote_dispatch.whitelist | 169 +++

[libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-07 Thread Matthias Bolte
--- daemon/Makefile.am | 20 - daemon/qemu_dispatch.blacklist |3 + daemon/qemu_dispatch.whitelist |1 + daemon/remote_dispatch.blacklist | 37 daemon/remote_dispatch.whitelist | 169 +++ daemon/remote_generator.