Re: [libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-04-08 Thread Eric Blake
On 4/7/19 1:32 AM, Michal Prívozník wrote: > On 4/7/19 6:16 AM, Roman Bogorodskiy wrote: >> Eric Blake wrote: >> >>> Had this been in place earlier, I would have avoided the bugs in >>> commit 0baf6945 and 55c2ab3e. Writing the test required me to extend >>> the power of virsh - creating enough s

Re: [libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-04-06 Thread Michal Prívozník
On 4/7/19 6:16 AM, Roman Bogorodskiy wrote: > Eric Blake wrote: > >> Had this been in place earlier, I would have avoided the bugs in >> commit 0baf6945 and 55c2ab3e. Writing the test required me to extend >> the power of virsh - creating enough snapshots to cause fanout >> requires enough input

Re: [libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-04-06 Thread Roman Bogorodskiy
Eric Blake wrote: > Had this been in place earlier, I would have avoided the bugs in > commit 0baf6945 and 55c2ab3e. Writing the test required me to extend > the power of virsh - creating enough snapshots to cause fanout > requires enough input in a single session that adding comments and > mark

Re: [libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-03-27 Thread Eric Blake
On 3/27/19 10:02 AM, Daniel P. Berrangé wrote: > On Sat, Mar 23, 2019 at 11:02:03PM -0500, Eric Blake wrote: >> Had this been in place earlier, I would have avoided the bugs in >> commit 0baf6945 and 55c2ab3e. Writing the test required me to extend >> the power of virsh - creating enough snapshots

Re: [libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-03-27 Thread Daniel P . Berrangé
On Sat, Mar 23, 2019 at 11:02:03PM -0500, Eric Blake wrote: > Had this been in place earlier, I would have avoided the bugs in > commit 0baf6945 and 55c2ab3e. Writing the test required me to extend > the power of virsh - creating enough snapshots to cause fanout > requires enough input in a single

[libvirt] [PATCH 5/5] snapshot: Add tests of virsh -c test:///default snapshot*

2019-03-23 Thread Eric Blake
Had this been in place earlier, I would have avoided the bugs in commit 0baf6945 and 55c2ab3e. Writing the test required me to extend the power of virsh - creating enough snapshots to cause fanout requires enough input in a single session that adding comments and markers makes it easier to check th