Re: [libvirt] [PATCH 6/8] util: new virCommandSetMax(MemLock|Processes|Files)

2013-04-25 Thread Eric Blake
On 04/25/2013 11:57 AM, Laine Stump wrote: > This patch adds two sets of functions: > > 1) lower level functions that will immediately set the > RLIMIT_MEMLOCK. RLIMIT_NPROC, or RLIMIT_NOFILE of either the current > process (using setrlimit()) or any other process (using prlimit()). > > 2) functi

Re: [libvirt] [PATCH 6/8] util: new virCommandSetMax(MemLock|Processes|Files)

2013-04-25 Thread Laine Stump
On 04/25/2013 03:27 PM, Daniel P. Berrange wrote: > Since these functions all take pid_t as their first arg, they should > all be named virProcessX and be located in virprocess.{c,h} rather > than virutil.{c,h} Yes, of course! The thought "Move it somewhere else!" was trying to come to my mind

Re: [libvirt] [PATCH 6/8] util: new virCommandSetMax(MemLock|Processes|Files)

2013-04-25 Thread Daniel P. Berrange
On Thu, Apr 25, 2013 at 01:57:56PM -0400, Laine Stump wrote: > diff --git a/src/util/virutil.c b/src/util/virutil.c > index b9de33c..058a069 100644 > --- a/src/util/virutil.c > +++ b/src/util/virutil.c > @@ -38,6 +38,10 @@ > #include > #include > #include > +#if HAVE_SETRLIMIT > +# include >

[libvirt] [PATCH 6/8] util: new virCommandSetMax(MemLock|Processes|Files)

2013-04-25 Thread Laine Stump
This patch adds two sets of functions: 1) lower level functions that will immediately set the RLIMIT_MEMLOCK. RLIMIT_NPROC, or RLIMIT_NOFILE of either the current process (using setrlimit()) or any other process (using prlimit()). 2) functions for virCommand* that will setup a virCommand object t